Skip to content

Comments

📚 Add ecosystem bar to account chooser dialog#5868

Merged
mahibi merged 2 commits intomasterfrom
feat/3248/ecosystem
Feb 19, 2026
Merged

📚 Add ecosystem bar to account chooser dialog#5868
mahibi merged 2 commits intomasterfrom
feat/3248/ecosystem

Conversation

@AndyScherzinger
Copy link
Member

@AndyScherzinger AndyScherzinger commented Feb 15, 2026

🖼️ Screenshots

⚙️ Settings 🏚️ Before/Off 🏡 After
settings before after

🚧 TODO

  • review and merge
  • ping @tobiasKaminsky afterwards for Brander implementation (equivalent to Notes client)

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@AndyScherzinger AndyScherzinger added this to the 23.1.0 milestone Feb 15, 2026
@AndyScherzinger AndyScherzinger added enhancement New feature or request design Related to the design 3. to review Waiting for reviews labels Feb 15, 2026
@AndyScherzinger AndyScherzinger changed the title Add ecosystem bar to account chooser dialog 🪟 Add ecosystem bar to account chooser dialog Feb 15, 2026
@AndyScherzinger AndyScherzinger changed the title 🪟 Add ecosystem bar to account chooser dialog 📚 Add ecosystem bar to account chooser dialog Feb 15, 2026
Copy link

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and nice positioning as discussed. :)

@mahibi
Copy link
Collaborator

mahibi commented Feb 16, 2026

Design wise it's fine.
Just the actual opening of the other apps fail for me.

I get

"Cannot open app store. Please install manually."

exception launching app [com.nextcloud.client, com.nextcloud.android.beta, com.nextcloud.android.qa]: android.content.ActivityNotFoundException: No Activity found to handle Intent { act=com.nextcloud.intent.OPEN_ECOSYSTEM_APP flg=0x30000000 xflg=0x4 pkg=com.nextcloud.client (has extras) }

but i guess that's something to be improved/fixed on android-commons..

@AndyScherzinger
Copy link
Member Author

@alperozturk96 to the rescue 😆

"Cannot open app store. Please install manually."

I guess cause it is a de-googlified phone?

exception launching app [com.nextcloud.client, com.nextcloud.android.beta, com.nextcloud.android.qa]: android.content.ActivityNotFoundException: No Activity found to handle Intent { act=com.nextcloud.intent.OPEN_ECOSYSTEM_APP flg=0x30000000 xflg=0x4 pkg=com.nextcloud.client (has extras) }

Might be the need for the latest version of the app @alperozturk96 upcoming 3.36 ?

@alperozturk96

This comment was marked as resolved.

@AndyScherzinger
Copy link
Member Author

@tobiasKaminsky @AndyScherzinger right and we must support it?

Ecosystem bar is non-branded only on all our clients

What is the exact package name of the app you tried to open?

It is fully using the common implementation calling https://github.com/nextcloud/android-common/blob/main/core/src/main/java/com/nextcloud/android/common/core/utils/ecosystem/EcosystemManager.kt#L62

So the issue @mahibi ran into is the Files client not supporting https://github.com/nextcloud/android-common/blob/main/core/src/main/java/com/nextcloud/android/common/core/utils/ecosystem/EcosystemManager.kt#L37 which I guess is due to the fact that the Files app is too old and than it breaks, right? So it will only work with 3.36+?

@AndyScherzinger AndyScherzinger force-pushed the feat/3248/ecosystem branch 2 times, most recently from dfc5b3f to 93669cf Compare February 18, 2026 08:23
Resolves: #3248

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
Copy link
Member Author

/backport to stable-23.0

@github-actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5868.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings9898
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1010
Dodgy code5454
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total8181

@mahibi
Copy link
Collaborator

mahibi commented Feb 18, 2026

I guess cause it is a de-googlified phone?

No, not de-googled

So the issue @mahibi ran into is the Files client not supporting https://github.com/nextcloud/android-common/blob/main/core/src/main/java/com/nextcloud/android/common/core/utils/ecosystem/EcosystemManager.kt#L37 which I guess is due to the fact that the Files app is too old and than it breaks, right? So it will only work with 3.36+?

yes, tested with files 3.35.2

Copy link
Collaborator

@mahibi mahibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine now when using a newer version of files app (tested with files version 3.37 alpha1)

@mahibi mahibi merged commit bc348ac into master Feb 19, 2026
19 of 21 checks passed
@mahibi mahibi deleted the feat/3248/ecosystem branch February 19, 2026 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews design Related to the design enhancement New feature or request feature: integration 🧩 feature: settings ⚙️

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tighter integration on apps within Nextcloud ecosystem

5 participants